Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unimplemented null return in class_loader_imp.hpp #160

Closed
danielwangksu opened this issue Jul 10, 2019 · 0 comments · Fixed by #163
Closed

unimplemented null return in class_loader_imp.hpp #160

danielwangksu opened this issue Jul 10, 2019 · 0 comments · Fixed by #163

Comments

@danielwangksu
Copy link

tinyxml2::XMLElement Attribute() may return NULL if none exists

pluginlib/pluginlib/include/pluginlib/class_loader_imp.hpp

Lines 668 to 669 in 54c925e

std::string library_path = library->Attribute("path");
if (0 == library_path.size()) {

artivis added a commit to artivis/pluginlib that referenced this issue Aug 19, 2019
@artivis
check for null ptr
2ad48a9 
  std::string my_string(NULL) is UB
  Fix ros#160

Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis mentioned this issue Aug 19, 2019
Merged
nuclearsandwich pushed a commit that referenced this issue Feb 14, 2020
@artivis
Check for NULL in XMLElement::Attribute (#163)
dfd49da 
std::string my_string(NULL) is UB
  Fix #160

Signed-off-by: artivis <jeremie.deray@canonical.com>
artivis added a commit to artivis/pluginlib that referenced this issue Feb 21, 2020
@artivis
Check for NULL in XMLElement::Attribute (ros#163)
0e35234 
std::string my_string(NULL) is UB
  Fix ros#160

Signed-off-by: artivis <jeremie.deray@canonical.com>
artivis added a commit to artivis/pluginlib that referenced this issue Feb 21, 2020
@artivis
Check for NULL in XMLElement::Attribute (ros#163)
cc64ec6 
std::string my_string(NULL) is UB
  Fix ros#160

Signed-off-by: artivis <jeremie.deray@canonical.com>
artivis added a commit to artivis/pluginlib that referenced this issue Feb 21, 2020
@artivis
Check for NULL in XMLElement::Attribute
9fbf57d 
std::string my_string(NULL) is UB
  Fix ros#160

Signed-off-by: artivis <jeremie.deray@canonical.com>
clalancette pushed a commit to artivis/pluginlib that referenced this issue Oct 23, 2020
@artivis @clalancette
Check for NULL in XMLElement::Attribute
532ad9b 
std::string my_string(NULL) is UB
  Fix ros#160

Signed-off-by: artivis <jeremie.deray@canonical.com>
clalancette pushed a commit that referenced this issue Oct 23, 2020
@artivis @clalancette
Check for NULL in XMLElement::Attribute
90c4fb4 
std::string my_string(NULL) is UB
  Fix #160

Signed-off-by: artivis <jeremie.deray@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for NULL in XMLElement::Attribute artivis/pluginlib
1 participant
@danielwangksu