Skip to content

Removed tinyxml2_vendor dependency #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
+3 −4
Merged

Removed tinyxml2_vendor dependency #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c72bf88
Removed tinyxml2_vendor dependency
ahcorde Sep 30, 2025
459bf45
Merge remote-tracking branch 'origin/rolling' into ahcorde/rolling/re…
ahcorde Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pluginlib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ find_package(ament_index_cpp REQUIRED)
find_package(class_loader REQUIRED)
find_package(rcutils REQUIRED)
find_package(rcpputils REQUIRED)
find_package(tinyxml2_vendor REQUIRED)
find_package(TinyXML2 REQUIRED) # provided by tinyxml2 upstream, or tinyxml2_vendor
find_package(TinyXML2 REQUIRED)

add_library(${PROJECT_NAME} INTERFACE)
target_include_directories(${PROJECT_NAME} INTERFACE
Expand All @@ -42,7 +41,7 @@ install(TARGETS list_plugins
DESTINATION lib/${PROJECT_NAME}
)

ament_export_dependencies(ament_index_cpp class_loader rcutils rcpputils tinyxml2_vendor TinyXML2)
ament_export_dependencies(ament_index_cpp class_loader rcutils rcpputils TinyXML2)

ament_export_targets(export_${PROJECT_NAME})

Expand Down
2 changes: 1 addition & 1 deletion pluginlib/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<depend>class_loader</depend>
<depend>rcutils</depend>
<depend>rcpputils</depend>
<depend>tinyxml2_vendor</depend>
<depend>tinyxml2</depend>

<test_depend>ament_cmake_gtest</test_depend>
<test_depend>ament_lint_auto</test_depend>
Expand Down