Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rostest in CMakeLists optional (ros/rosdistro#3010) #75

Merged
merged 2 commits into from
Oct 27, 2017

Conversation

bulwahn
Copy link

@bulwahn bulwahn commented Apr 15, 2017

This commit has the same intentions as commit f3f1c4d on the indigo branch.

This commit has the same intentions as commit f3f1c4d on the
indigo branch.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
@sloretz
Copy link
Contributor

sloretz commented Apr 17, 2017

@bulwahn Mind changing package.xml for rostest from <build_depend> to <test_depend> as well?

@sloretz
Copy link
Contributor

sloretz commented Oct 26, 2017

@bulwahn FYI I pushed the change to the package.xml onto your branch.

@clalancette mind looking at this once the build passes?

@bulwahn
Copy link
Author

bulwahn commented Oct 27, 2017

Thanks, I had this task on my todo list, but was too busy with travelling etc. With that additional commit, it should be ready to merge. Thanks again for taking care and please apologize my slacking in this pull request.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that kdl_parser and robot_model/urdf both have the same issue (rostest is a build_depend, not a test_depend); I'll open some PRs for that.

@sloretz sloretz merged commit 722eae7 into ros:kinetic-devel Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants