Fix check for header first in rosbag play for rate control topic #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to support sensor_msgs/Image, which has a comment after. Also note we only need to check for the type, not the name of the field.
|
@dirk-thomas @mikepurvis @tfoote for review FYI @mastereric |
|
Thank you for the improvement. |
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 20, 2018
* Skip empty lines * Only check 'Header ' is at the beginning This allows to support sensor_msgs/Image, which has a comment after. Also note we only need to check for the type, not the name of the field. * Break while loop after first field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check doesn't work for
sensor_msgs/Image(see definition here). This PR fixes it.Example code with the new checks for the
sensor_msgs/Imagedefinition: https://wandbox.org/permlink/1Oin9UytKs9JFf2h