Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for header first in rosbag play for rate control topic #1352

Merged
merged 3 commits into from
Mar 21, 2018

Conversation

efernandez
Copy link
Contributor

The check doesn't work for sensor_msgs/Image (see definition here). This PR fixes it.

Example code with the new checks for the sensor_msgs/Image definition: https://wandbox.org/permlink/1Oin9UytKs9JFf2h

This allows to support sensor_msgs/Image, which has a comment after.
Also note we only need to check for the type, not the name of the field.
@efernandez
Copy link
Contributor Author

@dirk-thomas @mikepurvis @tfoote for review

FYI @mastereric

@dirk-thomas
Copy link
Member

Thank you for the improvement.

@dirk-thomas dirk-thomas merged commit 2c8a3f6 into ros:lunar-devel Mar 21, 2018
dirk-thomas added a commit that referenced this pull request Apr 3, 2018
dirk-thomas pushed a commit that referenced this pull request Aug 20, 2018
* Skip empty lines

* Only check 'Header ' is at the beginning

This allows to support sensor_msgs/Image, which has a comment after.
Also note we only need to check for the type, not the name of the field.

* Break while loop after first field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants