Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-error type conformance in the Master_API #1472

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

KKostya
Copy link
Contributor

@KKostya KKostya commented Aug 3, 2018

  • Changed the default return value from 0 to [] in the @apivalidate arguments for the registerSubscriber and registerPublisher methods.
  • Similar typing tweak for the lookupService method.

The ROS Master XMLRPC API (http://wiki.ros.org/ROS/Master_API) defines registerSubscriber and registerPublisher return types to be (int, str, [str]). Yet, on an error, instead of a list of strings, it returns an integer.

This stricter typing is needed for our work on OCaml client project in ROS:
https://github.com/AestheticIntegration/imandra-ros/tree/master-api/rosocaml

@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Member

Thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants