On-error type conformance in the Master_API #1472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0
to[]
in the@apivalidate
arguments for theregisterSubscriber
andregisterPublisher
methods.lookupService
method.The ROS Master XMLRPC API (http://wiki.ros.org/ROS/Master_API) defines
registerSubscriber
andregisterPublisher
return types to be(int, str, [str])
. Yet, on an error, instead of a list of strings, it returns an integer.This stricter typing is needed for our work on OCaml client project in ROS:
https://github.com/AestheticIntegration/imandra-ros/tree/master-api/rosocaml