#961 revisited: Add default ROS_MASTER_URI #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepurvis
reviewed
Mar 21, 2019
jspricke
approved these changes
Mar 31, 2019
dirk-thomas
reviewed
Feb 8, 2020
cwecht
force-pushed
the
default_master_uri
branch
from
cc8bfae
to
440c61b
Compare
|
@cwecht Please comment on the PR after committing changes to the branch in the future. Otherwise nobody gets notified to revisit the PR. |
dirk-thomas
approved these changes
Feb 20, 2020
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replaces #961. The suggested changes have been made:
ros::getDefaultMasterURI()to roscppDEFAULT_MASTER_URIfrom rospy to rosgraph.rosenv, because it is needed there and import it from rospy is not possible, since this would introduce a circular dependency.