Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround for a race condition while closing the socket (#2212) #2233

Merged
merged 1 commit into from
May 31, 2022

Conversation

madmage
Copy link
Contributor

@madmage madmage commented Mar 15, 2022

This is not a fix but rather a workaround to avoid the exception when the socket is closed from two different threads (race condition). A proper fix would require to redesign the whole class to be thread safe. See #2212.

@jacobperron
Copy link
Contributor

Given the complexity involved in the code, I think this workaround is okay in lieu of a more involved fix.

@jacobperron jacobperron merged commit dd78ac8 into ros:noetic-devel May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants