roslaunch dependency on rospkg >=1.0.37 is not encoded or handled properly

[trainman419]

I'm working on some modifications to roslaunch; I started with the most recent version of roslaunch from the indigo-devel branch, but I'm getting errors when I try to run it:

Scanning dependencies of target run_tests_aw_planner_tests_rostest_tests_circle.launch
... logging to /home/default/.ros/log/rostest-15232-1193.log
Traceback (most recent call last):
  File "/home/default/ros_ws/src/driving/external/rostest/scripts/rostest", line 36, in <module>
    rostestmain()
  File "<string>", line 268, in rostestmain
  File "/home/default/ros_ws/src/driving/external/rostest/src/rostest/rostest_main.py", line 154, in rostestmain
    testCase = rostest.runner.createUnitTest(pkg, test_file, options.local, options.clear)
  File "/home/default/ros_ws/src/driving/external/rostest/src/rostest/runner.py", line 225, in createUnitTest
    config = roslaunch.parent.load_config_default([test_file], None)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/config.py", line 451, in load_config_default
    loader.load(f, config, verbose=verbose)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/xmlloader.py", line 730, in load
    self._load_launch(launch, ros_config, is_core=core, filename=filename, argv=argv, verbose=verbose)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/xmlloader.py", line 702, in _load_launch
    self._recurse_load(ros_config, launch.childNodes, self.root_context, None, is_core, verbose)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/xmlloader.py", line 666, in _recurse_load
    val = self._include_tag(tag, context, ros_config, default_machine, is_core, verbose)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/xmlloader.py", line 95, in call
    return f(*args, **kwds)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/xmlloader.py", line 587, in _include_tag
    inc_filename = self.resolve_args(tag.attributes['file'].value, context)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/xmlloader.py", line 183, in resolve_args
    return substitution_args.resolve_args(args, context=context.resolve_dict, resolve_anon=self.resolve_anon)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/substitution_args.py", line 353, in resolve_args
    resolved = _resolve_args(resolved, context, resolve_anon, commands)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/substitution_args.py", line 368, in _resolve_args
    resolved = commands[command](resolved, arg, args, context)
  File "/home/default/ros_ws/src/driving/external/roslaunch/src/roslaunch/substitution_args.py", line 144, in _find
    source_path_to_packages = rp.get_custom_cache('source_path_to_packages', {})

It looks like get_custom_cache was introduced in rosdep quite recently.

I've run rosdep install --from-paths src -i -y -r on my workspace, but it does not install the correct version of python-rosdep.

[wjwwood]

rosdep install ... doesn't consider the versions of packages installed, i.e. it ignores any version constraints in package.xml <*depend> tags.

[trainman419]

For reference, my machine currently has python-rospkg version 1.0.35-1 installed.

[wjwwood]

I think this is the corresponding rosdep issue (for the version enforcing): ros-infrastructure/rosdep#325

[trainman419]

There is no corresponding version_gte tag in the roslaunch manifest either.

[wjwwood]

Obviously that doesn't address the core issue which is the missing version dependency, but I just wanted to make sure you were aware that rosdep would update the package even if it were.

[dirk-thomas]

Good catch @trainman419.

Because of f2a5838#diff-85d266eabfa0eb4dda9a4551c1929065R137 roslaunch needs to declare a minimum version of ropskg.

[trainman419]

Thanks!