Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rospy] Add rospy.logXXX_once #1041

Merged
merged 3 commits into from
May 24, 2017
Merged

[rospy] Add rospy.logXXX_once #1041

merged 3 commits into from
May 24, 2017

Conversation

wkentaro
Copy link
Contributor

@wkentaro wkentaro commented Apr 30, 2017 •
edited
Loading

Following #812

@wkentaro wkentaro changed the title Add rospy.logXXX_once [rospy] Add rospy.logXXX_once Apr 30, 2017
dirk-thomas
dirk-thomas reviewed May 22, 2017
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the once logic should be built on top of the throttle logic. E.g. there is no call Time.now in order to implement once.

@dirk-thomas
Copy link
Member

dirk-thomas commented May 24, 2017 •
edited
Loading

Thank you. Can you please add the new logging functions to the wiki page mentioning that they are available as of ROS Lunar and post the link to the diff here.

@dirk-thomas dirk-thomas merged commit ec82978 into ros:lunar-devel May 24, 2017
@wkentaro wkentaro deleted the rospy_logxxx_once branch May 25, 2017 08:47
@wkentaro
Copy link
Contributor Author

Updated: http://wiki.ros.org/rospy/Overview/Logging#Logging_Once

@dirk-thomas
Copy link
Member

Thanks!

sputnick1124 pushed a commit to sputnick1124/ros_comm that referenced this pull request Jul 30, 2017
@wkentaro @sputnick1124
[rospy] Add rospy.logXXX_once (ros#1041)
8de892c 
* Add rospy.logXXX_once

* Stop using logging_throttle in once

* Revert LoggingThrottle
@dirk-thomas dirk-thomas mentioned this pull request Oct 26, 2017
Merged
@gavanderhoorn gavanderhoorn mentioned this pull request Nov 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkentaro @dirk-thomas