Improves the stability of SteadyTimerHelper. #1118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to scheduling / resource contention, `sleep`s and `wait_until`s may be delayed. The `SteadyTimerHelper` test class was not robust to these delays, which was likely the cause of a failing test (`multipleSteadyTimeCallbacks` in `timer_callbacks.cpp`:220).
Some unrelated python unit test appears to be failing...
|
This is a wild goose chase 🦆. This PR was supposed to fix tests so #1113 could get pulled in. It seems to have fixed the problem, but there are more failing tests downstream. |
|
So the problem seems to be caused by ros/roscpp_core#61. Not sure if the bug is in the test code here, or the range check there. |
|
Closing in favour of #1119. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to scheduling / resource contention,
sleeps andwait_untils may be delayed. TheSteadyTimerHelpertest class was not robust to these delays, which was likely the cause of a failing test (multipleSteadyTimeCallbacksintimer_callbacks.cpp:220).