rosnode_ping fix for issue #1967 #1986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2020 11:11
…ller_apis. Programmers also have the possibility to force looking up nodes from master by setting skip_cache to true.
|
Please split these changes into two PRs: one for the new |
|
@mabaue Friendly ping. |
|
@dirk-thomas |
|
@dirk-thomas Done. Two seperate PRs have been made |
@mabaue Can you please reference them here and close this PR if it is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1967
rosnode cleanup now also deletes unavailable nodes from
_caller_apiscache. This avoids buggy behaviour when nodes exit the ros network due to wifi issues and then come back later.Programmers also have to possibility to skip that cache when calling
rosnode_pingorrosnode_ping_all.