make LogAppender destructor virtual #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should also be a virtual destructor in the ros::console::Token class. |
dirk-thomas
force-pushed
the
log_appender_virtual_destructor
branch
from
4af4faa
to
f69dec0
Compare
dirk-thomas
force-pushed
the
log_appender_virtual_destructor
branch
from
f69dec0
to
f89d21f
Compare
|
This makes me happy. |
dirk-thomas
added a commit
that referenced
this pull request
Mar 18, 2016
make LogAppender destructor virtual
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
make LogAppender destructor virtual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #729.