Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bool Service #7

Closed
wants to merge 1 commit into from
Closed

Add Bool Service #7

wants to merge 1 commit into from

Conversation

pantor
Copy link

@pantor pantor commented Oct 9, 2015

I often use a service with an additional bool field in my projects, e.g. for motor enabling/disabling, for switching a notification LED or to turn on/off a laser pointer. Any chance that it might be added to the std_srvs package?

@DaikiMaekawa
Copy link

👍 I agree your PR because I often add the Bool.srv for our projects.

@dirk-thomas
Copy link
Member

We have talked about this and came to the following conclusions:

  • In general the generic std_msgs and std_srvs should only be used for prototyping since they don't contain any semantic meaning.
  • Considering that the other service is called Trigger this one would be more specifically names with SetBool.
  • For semantic meaning a return code should be an integer (not a bool) with return codes defined in the service itself.
  • We do see the value of having a SetBool for rapid prototyping though.
  • But we won't add additional services like SetInt since those would lack too much semantic on the request data (valid value range, unit, etc.).

That being said I have cherry-picked a modified version of this with the service name being called SetBool in 688af91

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants