Skip to content

get rid of deprecated rclcpp::spin_some() #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

get rid of deprecated rclcpp::spin_some() #183

merged 1 commit into from
Aug 25, 2025
+5 −1

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 21, 2025

Related with ros2/rclcpp#2848

@ahcorde
get rid of deprecated rclcpp::spin_some()
de83b22 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Aug 21, 2025
fujitatomoya
fujitatomoya approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i missed this one, thanks. i was doing grep only under ros2 organization.

@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 22, 2025

Pulls: #183
Gist: https://gist.githubusercontent.com/ahcorde/ef1e89eca12fe0a4e94d73ad8932295a/raw/afac88e2b899a924041d595756d87fc48dfc9795/ros2.repos
BUILD args: --packages-above-and-dependencies turtlesim
TEST args: --packages-above turtlesim
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16774

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Contributor

@ahcorde i do not have power to merge this, can you do me a favor?

@fujitatomoya fujitatomoya mentioned this pull request Aug 23, 2025
Merged
@ahcorde ahcorde merged commit 308b477 into rolling Aug 25, 2025
3 checks passed
@ahcorde ahcorde deleted the ahcorde/deprecate-global-spin-some-all branch August 25, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@alsora alsora alsora approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @fujitatomoya @alsora