Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rviz_camera_stream to noetic #30895

Closed
wants to merge 1 commit into from
Closed

Conversation

lucasw
Copy link
Contributor

@lucasw lucasw commented Sep 30, 2021

Please Add This Package to be indexed in the rosdistro.

noetic

The source is here:

https://github.com/lucasw/rviz_camera_stream

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@lucasw
Copy link
Contributor Author

lucasw commented Sep 30, 2021

It's failing on

AssertionError: ["In file '''/home/runner/work/rosdistro/rosdistro/noetic/distribution.yaml''': Could not validate source entry for repo rviz_camera_stream with error [[[Could not validate repository with url https://github.com/lucasw/rviz_camera_stream.git and version 1.0.1 from entry at line 8059. Error reason: Tags are not valid, but a tag 1.0.1 was found. Re: https://github.com/ros/rosdistro/pull/20286]]]"] is not false

Did I enter the version into bloom incorrectly?

@audrow
Copy link
Contributor

audrow commented Oct 1, 2021

I'm not sure why it shows different versions for the docs and release, maybe try redoing this? Also, is there any reason that you didn't use bloom?

@audrow audrow added the changes requested Maintainers have asked for changes to the pull request label Oct 1, 2021
@lucasw
Copy link
Contributor Author

lucasw commented Oct 2, 2021

Also, is there any reason that you didn't use bloom?

I got tripped up with the github authentication, couldn't figure out why I couldn't use ssh git@github for urls involved with pushing instead of https:// and having to jump through extra authentication steps. But I can try it again. (It would be really nice if it were possible to specify all the options in a config file instead of the interactive bash script- or maybe it is but the main documentation steered me away from that?)

@lucasw
Copy link
Contributor Author

lucasw commented Oct 2, 2021

I'm not sure why it shows different versions for the docs and release

I figured it out from the other entries in the distibution.yaml, the version for doc and source is the branch name, not a tag like it is with release.

@mabelzhang
Copy link
Contributor

You should be able to use the SSH URL. Have you tried this? http://wiki.ros.org/bloom/Tutorials/GithubManualAuthorization
We recommend using Bloom, and it would be good for future releases if you get it set up correctly now.

@lucasw
Copy link
Contributor Author

lucasw commented Oct 4, 2021

You should be able to use the SSH URL

I ran into this initially when I first tried to use git@github

https://github.com/ros-infrastructure/bloom/blob/cca7ec80c0cb2234e280bb23741b5fe02345db0d/bloom/commands/release.py#L179-L190

but then later in the process it asks about a push url, and I thought the early url goes through validation and has to be https as required by the above code, but then the push url could be git@github.com- but it didn't work, possibly something else I manually typed in tripped it up. Does a file get saved after all the interactive steps, I could look at a working example or show what I already tried, or even better just hand edit that and execute bloom with it until succeeding and avoid the text entry altogether?

@mabelzhang
Copy link
Contributor

Bloom by default pushes with HTTPS, which is what the page I linked above does; it reroutes HTTPS through SSH.
When you say initially it didn't work, which step on that page did you run into an error, and what was the error message?

@hidmic
Copy link
Contributor

hidmic commented Oct 7, 2021

@lucasw let's try to re-release using bloom. If you get blocked, I can provide immediate feedback. Just tag me.

@ivanpauno
Copy link
Contributor

@lucasw I will close this PR for the moment, please reopen or open a new PR when this is ready for review again.
If you have any question feel free to tag me.

@ivanpauno ivanpauno closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants