-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rviz_camera_stream to noetic #30895
Conversation
45e84b1
to
3a533d0
Compare
It's failing on
Did I enter the version into bloom incorrectly? |
I'm not sure why it shows different versions for the docs and release, maybe try redoing this? Also, is there any reason that you didn't use bloom? |
I got tripped up with the github authentication, couldn't figure out why I couldn't use ssh |
3a533d0
to
2f7a3ad
Compare
I figured it out from the other entries in the distibution.yaml, the |
You should be able to use the SSH URL. Have you tried this? http://wiki.ros.org/bloom/Tutorials/GithubManualAuthorization |
I ran into this initially when I first tried to use git@github but then later in the process it asks about a push url, and I thought the early url goes through validation and has to be https as required by the above code, but then the push url could be git@github.com- but it didn't work, possibly something else I manually typed in tripped it up. Does a file get saved after all the interactive steps, I could look at a working example or show what I already tried, or even better just hand edit that and execute bloom with it until succeeding and avoid the text entry altogether? |
Bloom by default pushes with HTTPS, which is what the page I linked above does; it reroutes HTTPS through SSH. |
@lucasw let's try to re-release using |
@lucasw I will close this PR for the moment, please reopen or open a new PR when this is ready for review again. |
Please Add This Package to be indexed in the rosdistro.
noetic
The source is here:
https://github.com/lucasw/rviz_camera_stream
Checks