Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add off_highway_sensor_drivers #39861

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

shu-beg
Copy link
Contributor

@shu-beg shu-beg commented Feb 9, 2024

Please add the following dependency to the rosdep database.

Package name:

meta package: off_highway_sensor_drivers
with packages:

  • off_highway_can
  • off_highway_general_purpose_radar
  • off_highway_general_purpose_radar_msgs
  • off_highway_premium_radar
  • off_highway_premium_radar_msgs
  • off_highway_radar
  • off_highway_radar_msgs
  • off_highway_uss
  • off_highway_uss_msgs

Package Upstream Source:

Purpose of using this:

This project provides ROS drivers for Bosch Off-Highway sensor systems. The drivers are used by various users in the off-highway domain, they request availability of prebuilt packages.

Distro packaging links:

Links to Distribution Packages

Should be built by ROS buildfarm (ros2-gbp), links not available yet

Please Add This Package to be indexed in the rosdistro.

humble

The source is here:

https://github.com/bosch-engineering/off_highway_sensor_drivers

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Feb 9, 2024
@shu-beg shu-beg changed the title added off_highway_sensor_drivers Add off_highway_sensor_drivers Feb 9, 2024
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • At least one of the following must be present
    • Top level license file:
    • Per package license files
  • License is OSI-approved:
  • License correctly listed in package.xmls
  • Public source repo:
  • Source repository contains ROS packages
  • Each package meets REP-144 naming conventions
Package name details
$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
  <name>off_highway_premium_radar_msgs</name>
  <name>off_highway_can</name>
  <name>off_highway_radar</name>
  <name>off_highway_uss_msgs</name>
  <name>off_highway_premium_radar</name>
  <name>off_highway_general_purpose_radar_msgs</name>
  <name>off_highway_uss</name>
  <name>off_highway_sensor_drivers</name>
  <name>off_highway_general_purpose_radar</name>
  <name>off_highway_radar_msgs</name>
License details
$ find . -name "package.xml" -exec grep --color=auto -e "<license[^>]*>" "{}" "+"
./off_highway_premium_radar_msgs/package.xml:  <license>Apache-2.0</license>
./off_highway_can/package.xml:  <license>Apache-2.0, MIT</license>
./off_highway_radar/package.xml:  <license>Apache-2.0</license>
./off_highway_uss_msgs/package.xml:  <license>Apache-2.0</license>
./off_highway_premium_radar/package.xml:  <license>Apache-2.0</license>
./off_highway_general_purpose_radar_msgs/package.xml:  <license>Apache-2.0</license>
./off_highway_uss/package.xml:  <license>Apache-2.0</license>
./off_highway_sensor_drivers/package.xml:  <license>Apache-2.0</license>
./off_highway_general_purpose_radar/package.xml:  <license>Apache-2.0</license>
./off_highway_radar_msgs/package.xml:  <license>Apache-2.0</license>

@sloretz sloretz merged commit 015903d into ros:master Feb 9, 2024
4 checks passed
@Timple
Copy link
Contributor

Timple commented Feb 12, 2024

Awesome! Would an iron release also be possible? 👼

@marcusvinicius178
Copy link

Awesome! Would an iron release also be possible? 👼

Hey @Timple that would be amazing. I am also working with an off-road project and compiled the ros2-humble https://github.com/bosch-engineering/off_highway_sensor_drivers.

However I had these issues: bosch-engineering/off_highway_sensor_drivers#5

Were you able to get PCD radar data using ROS2 Iron ( from /objects_pcl topic)?

@shu-beg shu-beg deleted the off_highway_sensor_drivers branch April 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants