Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2_socketcan: 1.3.0-1 in 'humble/distribution.yaml' [bloom] #42111

Closed
wants to merge 1 commit into from

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jul 16, 2024

Increasing version of package(s) in repository ros2_socketcan to 1.3.0-1:

ros2_socketcan

* Jazzy release
* fix: add missing header (#42 <https://github.com/autowarefoundation/ros2_socketcan/issues/42>)
* Allow remapping of the canbus topics (#39 <https://github.com/autowarefoundation/ros2_socketcan/issues/39>)
* Contributors: Joshua Whitley, Tim Clephas

ros2_socketcan_msgs

* Jazzy release

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 16, 2024

Even though the change logs say "Jazzy release", this is also a bump for iron and humble too.

Related PRs for this release:

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 16, 2024

https://github.com/ros/rosdistro/actions/runs/9963389750/job/27529319430?pr=42111#step:6:356

Hmm

E               RuntimeError: humble: missing package.xml file for package "ros2_socketcan"
E               humble: missing package.xml file for package "ros2_socketcan_msgs"

@christophebedard
Copy link
Member

christophebedard commented Jul 16, 2024

Looks like you haven't released 1.3.0 for Humble: https://github.com/ros2-gbp/ros2_socketcan-release/blob/master/tracks.yaml

The push to the release repo probably didn't work. You can just re-do the bloom-release command.

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 16, 2024

@christophebedard For some reason https://github.com/autowarefoundation/ros2_socketcan-release this repo started existing at some point and it has the humble release 😕

Or it always existed, I'm not sure :|

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 16, 2024

Here are the outputs from my command:

mfc@mfc-leo:~/projects/socketcan_ws/src/ros2_socketcan$ bloom-release --rosdistro humble ros2_socketcan
ROS Distro index file associate with commit '38d2b9367edaa3e107cb37f97467a6ea216e6f8a'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/38d2b9367edaa3e107cb37f97467a6ea216e6f8a/index-v4.yaml'
==> Fetching 'ros2_socketcan' repository from 'https://github.com/ros2-gbp/ros2_socketcan-release.git'
Cloning into '/tmp/tmpsoxkp1z0'...
remote: Enumerating objects: 2286, done.
remote: Counting objects: 100% (486/486), done.
remote: Compressing objects: 100% (353/353), done.
remote: Total 2286 (delta 149), reused 419 (delta 114), pack-reused 1800
Receiving objects: 100% (2286/2286), 402.86 KiB | 1.88 MiB/s, done.
Resolving deltas: 100% (653/653), done.
==> Setting release repository remote url to 'git@github.com:autowarefoundation/ros2_socketcan-release.git'
==> git remote set-url origin git@github.com:autowarefoundation/ros2_socketcan-release.git
==> Testing for push permission on release repository

...

Not sure why it picked github.com:autowarefoundation/ros2_socketcan-release.git

@christophebedard
Copy link
Member

christophebedard commented Jul 16, 2024

It's because that's the URL that your release config uses. You need to change the release repo URL here to the ros2-gbp release repo: https://github.com/ros2-gbp/ros2_socketcan-release/blob/2138b0ceb8fb4a9b805b6d634f55ca4d681e2348/tracks.yaml#L75. The URL here in humble/distribution.yaml is OK; seems like it was changed to ros2-gbp some time ago. Then you can try bloom-release again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants