Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2_socketcan: 1.3.0-1 in 'humble/distribution.yaml' [bloom] #42117

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jul 16, 2024

Increasing version of package(s) in repository ros2_socketcan to 1.3.0-1:

ros2_socketcan

* Jazzy release
* fix: add missing header (#42 <https://github.com/autowarefoundation/ros2_socketcan/issues/42>)
* Allow remapping of the canbus topics (#39 <https://github.com/autowarefoundation/ros2_socketcan/issues/39>)
* Contributors: Joshua Whitley, Tim Clephas

ros2_socketcan_msgs

* Jazzy release

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Jul 16, 2024
@christophebedard
Copy link
Member

Looks good now!

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 16, 2024

@christophebedard Thanks for all the help, this was one of the most complicated things I did in my life (first time releasing a package with bloom).

It would have taken me way too much time to figure out the issue with humble release_repo_url being wrong.
I don't even know why humble and older distros point to the autowarefoundation fork of the repo. Or why the fork exists at all (maybe https://github.com/ros2-gbp/ros2-gbp-github-org system of handling user permissions didn't exist back then?)

I hope everything works out in the long run, I think I did all that I could, hopefully right 😅

@christophebedard christophebedard merged commit 5f10872 into ros:master Jul 16, 2024
4 checks passed
@xmfcx xmfcx deleted the bloom-ros2_socketcan-0 branch July 16, 2024 20:49
@christophebedard
Copy link
Member

Yeah, at some point a lot of release repos were moved to https://github.com/ros2-gbp/. I assume some of the URLs were just not updated.

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 16, 2024

Should I remove or archive the autowarefoundation fork and update the release_repo_url of all the other distros too?

@christophebedard
Copy link
Member

I think you can definitely archive it (so that it is read-only). Then you can just let the end-of-life distros (i.e., Galactic and older) keep pointing to it; no need to change those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants