Implement EXCLUDE

[mikepurvis]

To eliminate files from linting (eg, tests, files which come from elsewhere, etc).

Should support individual files or globs.

[jack-oquin]

I would prefer to simplify the commands so they always take a list of the files needing lint processing. That makes generating the names more flexible, while showing it explicitly in the CMakeLists.txt.

file(GLOB_RECURSE ${PROJECT_NAME}_PYTHON_SRCS *.py)
roslint_python(${${PROJECT_NAME}_PYTHON_SRCS})

Exclude can then be done as usual in CMake, and we can do more complex globbing. Supposing the executable scripts have no .py suffix:

file(GLOB_RECURSE ${PROJECT_NAME}_PYTHON_MODS src *.py)
list(REMOVE_ITEM ${PROJECT_NAME}_PYTHON_MODS 
     src/${PROJECT_NAME}/foo.py
     src/${PROJECT_NAME}/bar.py)
file(GLOB ${PROJECT_NAME}_PYTHON_SCRIPTS scripts *)
roslint_python(${${PROJECT_NAME}_PYTHON_MODS} 
               ${${PROJECT_NAME}_PYTHON_SCRIPTS})

[mikepurvis]

That makes sense to me—let's do it that way.

[jack-oquin]

OK.

Aside from documentation, it will be simple to implement.

[jack-oquin]

The commit above looks like it should work, but has not been tested.

I'll keep this issue open until we have unit tests that demonstrate that it works as expected.

As coded, the list of sources may be empty. Pylint will complain in that case. A better solution would test for it and print a warning message, instead.

[jack-oquin]

The unit tests seem to be working OK now. Closing this issue.