Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to run linter with tests #11

Closed
mikepurvis opened this issue Oct 17, 2013 · 1 comment
Closed

Add option to run linter with tests #11

mikepurvis opened this issue Oct 17, 2013 · 1 comment

Comments

@mikepurvis
Copy link
Member

For example:

roslint_python(src/mypkg/foo.py AS_TEST lint_python)

We would create the roslint and roslint_mypkg targets as usual, but also create a run_tests_mypkg_lint_python target, depended upon by run_tests. The idea would be that you could optionally have the linter check run as part of the CI's run_tests build.

On the implementation side, we should be able to call catkin_run_tests_target to wire it up, though you need to provide xunit xml output for that; that aspect of this intersects with #9. (And there may need to be transformation stage in there, to coerce the line-by-line output into the requisite XML.)

@jack-oquin
Copy link
Member

+1 Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants