Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to time msg bug #392

Closed
wants to merge 14 commits into from
Closed

Conversation

Guelakais
Copy link
Contributor

@Guelakais Guelakais commented Apr 18, 2024

Mentioning (#385)
So what I basically tried was to adapt the rosidl_generator_rs so that it generates publishable rust crates from ros2 message types, as you can see here. that worked reasonably well and since the build worked much better than before, I thought I had solved the problem.

I also read up on the licences of these guys beforehand, so I thought I was on the safe side in this case. Unfortunately, some of these types cannot be deleted from crates.io without further ado. You have to yank them, whereby crates.io first checks whether this dependency is used anywhere. This check is currently running.

@esteve
Copy link
Collaborator

esteve commented Apr 18, 2024

@Guelakais thanks for working on this. Could you update the description and the title to reflect what these changes do / fix? We follow this convention for any PR that is submit, it helps us track issues and PRs better. Thanks.

@esteve
Copy link
Collaborator

esteve commented Apr 18, 2024

I've noticed you've published a bunch of crates on crates.io that contain the messages, it'd have been nice to notify us beforehand, there's a reason we haven't published them ourselves. This can cause breakages in existing code and conflicting dependencies, please delete them from crates.io

Can you add any of us as maintainers on crates.io so that we can fix this situation if you can't? Thanks

@Guelakais
Copy link
Contributor Author

Ah, I didn't know that. So the pull request is of course invalid. I thought it might work because of the licences used. Sorry about that.

@esteve
Copy link
Collaborator

esteve commented Apr 18, 2024

Don't worry, I know the intention was good. Let me see if it's possible to delete crates from crates.io, in the meantime, could you add me as a maintainer?

@esteve
Copy link
Collaborator

esteve commented Apr 19, 2024

crates.io has the policy of not removing crates, they can only be yanked, but the crates are going to be there forever. We'll need to rethink how messages are included during the build to avoid crates.io potentially interfering in the future.

@esteve esteve closed this Apr 19, 2024
@esteve
Copy link
Collaborator

esteve commented Apr 19, 2024

@Guelakais can you add me as a maintainer to the other crates on crates.io? You've only added me to action_msgs, geometry_msgs and lanelet_msgs. I'm going to update their descriptions so that people don't ask us about them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants