Add arm7l compatability to ROS2 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
reviewed
Nov 19, 2020
| @@ -79,6 +79,11 @@ else () | |||
| set (MMK_ABI "arm") | |||
| set (MMK_BITS 32) | |||
| set (MMK_ARCH_ARM 1) | |||
| elseif (_ARCH MATCHES "armv7l") | |||
There was a problem hiding this comment.
@rydb why not adding v7l to the ARM32 regex above?
There was a problem hiding this comment.
arm7l is a different architecture from arm32, if not explicitly stated as seperate architecture option, it won't be detected as a compatible architecture.
There was a problem hiding this comment.
I may have pinged and not seen your first question. Sorry about that.
Point is, v7l is a 32 bits ARM processor. So instead of replicating the if clause, consider adding v7l to the regex in line 26.
rydb
commented
Dec 17, 2020
| @@ -79,6 +79,11 @@ else () | |||
| set (MMK_ABI "arm") | |||
| set (MMK_BITS 32) | |||
| set (MMK_ARCH_ARM 1) | |||
| elseif (_ARCH MATCHES "armv7l") | |||
| @@ -79,6 +79,11 @@ else () | |||
| set (MMK_ABI "arm") | |||
| set (MMK_BITS 32) | |||
| set (MMK_ARCH_ARM 1) | |||
| elseif (_ARCH MATCHES "armv7l") | |||
There was a problem hiding this comment.
arm7l is a different architecture from arm32, if not explicitly stated as seperate architecture option, it won't be detected as a compatible architecture.
|
Superseded by #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a patch to ros2/Mimick using Snaipe#17 (comment) 's workaround and after removing Rviz(which breaks due to missing atomic functions from the pi), I was able to successfully compile ros2 for the pi 4.