add description for CI_ROS2_REPOS_URL #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhood
reviewed
Dec 2, 2016
| <name>CI_ROS2_REPOS_URL</name> | ||
| <description>Custom .repos file to use instead of the default (https://raw.githubusercontent.com/ros2/ros2/master/ros2.repos). | ||
| For example, copy the content of the .repos file to a GitHub Gist, modify it to your needs, and then pass the raw URL here.</description> | ||
| <defaultValue></defaultValue> |
There was a problem hiding this comment.
how about putting https://raw.githubusercontent.com/ros2/ros2/master/ros2.repos into a variable, templating it into the description, and passing it to the defaultValue here instead of at this line? (so the description doesn't get out-dated if the default changes)
There was a problem hiding this comment.
Done: 95d442da4b353194cfc383f4f6c01ebcb680298e
dhood
approved these changes
Dec 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides that the PR refactors some stuff to avoid duplication:
.templateto.em(because that is the language they use, then https://atom.io/packages/language-empy will also highlight them nicely 😉)In order to deploy this #9 needs to be merged since otherwise the already deployed changes of that PR will be reverted.