not add delimiters if already there #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
force-pushed
the
delimiters
branch
from
9c0f479 to
1ce2900
Compare
dirk-thomas
suggested changes
Dec 5, 2016
| @@ -143,10 +143,16 @@ if [ "$CI_ENABLE_C_COVERAGE" = "true" ]; then | |||
| export CI_ARGS="$CI_ARGS --coverage" | |||
| fi | |||
| if [ -n "${CI_AMENT_BUILD_ARGS+x}" ]; then | |||
| export CI_ARGS="$CI_ARGS --ament-build-args $CI_AMENT_BUILD_ARGS --" | |||
| if [[ "$CI_AMENT_BUILD_ARGS" != *-- ]]; then | |||
| CI_AMEND_BUILD_ARGS="$CI_AMENT_BUILD_ARGS --" | |||
There was a problem hiding this comment.
Spelling error: CI_AMEND_BUILD_ARGS (D vs T)
Same below.
There was a problem hiding this comment.
good catch thanks fe1e2fc
dirk-thomas
approved these changes
Dec 5, 2016
This was referenced Dec 5, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #9 (comment)