Don't COLCON_IGNORE fastcdr, we want to use it for rosbag2 type conversion

[emersonknapp]

@nuclearsandwich let me know what you think about this, we currently have a dependency from rosbag2 converters on rmw_fastrtps_cpp, but only need the CDR implementation and are looking to pull a dependency on it directly. Noticed that in the packaging builds it is ignored if "USE_FASTRTPS_*" is not checked. We're thinking this library should be usable as a dependency even if the middleware itself is not being used.

[clalancette]

That makes sense to me, but I'll let @nuclearsandwich review before merging.

[Karsten1987]

nice

[clalancette]

@emersonknapp Can you please run a CI with this change in place, just to ensure that nominal things still work?

[emersonknapp]

@emersonknapp Can you please run a CI with this change in place, just to ensure that nominal things still work?

Given that I do not have write access to this repo and can't push my feature branch to it, I'm not sure that I am able to do so. My understanding is that CI_SCRIPTS_BRANCH parameter is used on builds to achieve this, but that the branch has to be present on this repository, not a fork.

[nuclearsandwich]

@emersonknapp I pushed your branch to ros2/ci directly so it can be used with CI_SCRIPTS_BRANCH. The branch name is unchanged (emersonknapp/no-ignore-cdr)

[emersonknapp]

Thanks! Anything I should run beyond:

• ci_packaging_linux:

?

[clalancette]

I guess the other thing test to run is when both Fast-RTPS static and Fast-RTPS dynamic are unchecked. I don't expect problems, really (we're just adding a new package in that case), but we may as well check it.

[emersonknapp]

Of course, makes sense

•