Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install the liborocos-kdl-dev system package #668

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Install the liborocos-kdl-dev system package #668

merged 1 commit into from
Jun 23, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 21, 2022 •
edited
Loading

This package is already installed for RHEL.

Linux Build Status

@cottsay cottsay requested a review from clalancette June 21, 2022 16:43
@cottsay cottsay self-assigned this Jun 21, 2022
@cottsay cottsay mentioned this pull request Jun 21, 2022
Merged
clalancette
clalancette approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Should we hold off on merging this until we understand what is causing e.g. https://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_debug/2009 ? I just don't want to bust the cache and then have everything fail until we have that fixed.

@cottsay
Copy link
Member Author

cottsay commented Jun 22, 2022

Should we hold off on merging this...?

@nuclearsandwich and @Blast545, does a Docker cache bust worry you right now?

@Blast545
Copy link
Contributor

@cottsay I haven't seen the error in any of the nightlies, I think it's good to merge now. I'm re running your original build to make double check before merging.

Linux CI:
Build Status

Blast545
Blast545 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge after confirmation build ends

@Blast545
Copy link
Contributor

LGTM to merge ping

@nuclearsandwich
Copy link
Member

@nuclearsandwich and @Blast545, does a Docker cache bust worry you right now?

Bring it on. If problems are created that means that #667 is incomplete somehow and needs to be dealt with.

@cottsay cottsay merged commit e40afe7 into master Jun 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the cottsay/liborocos-kdl-dev branch June 23, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@Blast545 Blast545 Blast545 approved these changes

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cottsay @Blast545 @nuclearsandwich @clalancette