Ensure orocos-kdl is available as a target #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
This seems reasonable to me, though I note some of the CI jobs you ran are failing.
Orthogonally, can you please open up a change to https://github.com/ros2/ci to install orocos in our Ubuntu (and RHEL, if available) docker containers? That way CI is more like what the buildfarm does.
Looks like an infra issue, I re-ran them and they're past the previous point of failure.
Done: ros2/ci#668 |
|
@Mergifyio backport humble |
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
(cherry picked from commit 06c1aab)
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6 ensures that the
orocos-kdltarget exported by Orocos KDL versions newer than 1.5.1 will include the Eigen3 directories. This PR ensures that the target is present by creating a new "imported" library and populating it based on the old-style_LIBRARIESand_INCLUDE_DIRSvariables.This wasn't caught in the original PR because the
orocos_kdl_vendorpackage includes additional changes after 1.5.1 was tagged which export the target, and ci.ros2.org isn't installingliborocos-kdl-dev. I was able to reproduce the problem using the build.ros2.org CI jobs.From build.ros2.org:
With CI changes:
Current CI:
Paris with: