Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not run linters on repeated nightly #9

Merged
merged 4 commits into from
Dec 5, 2016
Merged

do not run linters on repeated nightly #9

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54e9b76
do not run linters on repeated nightly
mikaelarguedas Nov 7, 2016
78211f1
fix label name
mikaelarguedas Nov 7, 2016
10b4ef5
pass ctest-args
mikaelarguedas Nov 7, 2016
b64c7b9
remove duplicated delimiter
mikaelarguedas Nov 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion create_jenkins_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def main(argv=None):
job_name = job_name[0:-5]
job_data['time_trigger_spec'] = '0 12 * * *'
job_data['cmake_build_type'] = 'None'
job_data['ament_test_args_default'] = '--retest-until-fail 20'
job_data['ament_test_args_default'] = '--retest-until-fail 20 --ctest-args -LE linter --'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what's happening here is that the --ctest-args (greedy) are being nested within another greedy argument --ament-test-args that gets the delimeter appended here. Really these two lists should have different variables.

As you mentioned offline, this will work as-is for now, so we can apply it to the farm, but let's not merge it until it's implemented in a way that's more future-proof

job_config = expand_template('ci_job.xml.template', job_data)
configure_job(jenkins, job_name, job_config, **jenkins_kwargs)

Expand Down