Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a compatibility layer for older versions of numpy. #185

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

clalancette
Copy link
Contributor

Specifically, the version of numpy in RHEL 8 is 1.14, which
lacks the structured_to_unstructured and unstructured_to_structured
methods of numpy 1.16 and later. Add in compatibility versions
here.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

FYI @Flova , this is fallout from #175

Specifically, the version of numpy in RHEL 8 is 1.14, which
lacks the structured_to_unstructured and unstructured_to_structured
methods of numpy 1.16 and later.  Add in compatibility versions
here.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • RHEL Build Status

Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clalancette
Copy link
Contributor Author

CI is green, and approved, so going ahead and merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants