Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added serialized listener demo for python #287

Merged

Conversation

josephduchesne
Copy link
Contributor

@josephduchesne josephduchesne commented Nov 25, 2018

Connects to ros2/rclpy#242

This was added at the suggestion of @Karsten1987 for ros2/rclpy/pull/242

This is a python analog of listener_serialized_message.cpp in demo_nodes_cpp.

For it to work, you need to be on the rclpy branch in my pull request, or that PR has to be merged in.

As a result, this should not be merged until ros2/rclpy/pull/242 is.

@tfoote tfoote added the in review Waiting for review (Kanban column) label Nov 25, 2018
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. A few minor nitpicks

demo_nodes_py/demo_nodes_py/topics/listener_serialized.py Outdated Show resolved Hide resolved
demo_nodes_py/demo_nodes_py/topics/listener_serialized.py Outdated Show resolved Hide resolved
@Karsten1987
Copy link
Contributor

@josephduchesne I hope you don't mind. I edited your comment to connect this PR to your rclpy one in a way that the waffle board picks it up.

@Karsten1987 Karsten1987 merged commit 9469477 into ros2:master Jan 10, 2019
@Karsten1987 Karsten1987 removed the in review Waiting for review (Kanban column) label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants