-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for OpenCV v4.0 compatibility #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as it passes CI on Xenial, our current Windows builds, and MacOS with the latest OpenCV formula.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, with one comment.
Thanks for looking into it.
image_tools/src/burger.cpp
Outdated
@@ -124,7 +124,7 @@ cv::Mat & Burger::render_burger(size_t width, size_t height) | |||
} | |||
burger_buf = cv::Mat(height_i, width_i, CV_8UC3); | |||
} | |||
burger_buf = cvScalar(0, 0, 0); | |||
burger_buf = cv::Scalar_<int>(0, 0, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason you're using int
specifically rather than double
, i.e. cv::Scalar
? I assume there is, but I'm just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, no. I think this should just be cv::Scalar
😬
Fixed in 2877adb
No description provided.