Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to avoid deprecated API's #332

Merged
merged 1 commit into from
May 8, 2019
Merged

changes to avoid deprecated API's #332

merged 1 commit into from
May 8, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 7, 2019

Connects to ros2/rclcpp#713

@wjwwood
changes to avoid deprecated API's
b73ab4e 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the in review Waiting for review (Kanban column) label May 7, 2019
@wjwwood wjwwood self-assigned this May 7, 2019
ivanpauno
ivanpauno reviewed May 7, 2019
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, LGTM.

demo_nodes_cpp/src/topics/talker.cpp Show resolved Hide resolved
demo_nodes_cpp/src/topics/talker_serialized_message.cpp Show resolved Hide resolved
image_tools/src/cam2image.cpp Show resolved Hide resolved
@ivanpauno ivanpauno mentioned this pull request May 7, 2019
Merged
ivanpauno
ivanpauno approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjwwood wjwwood merged commit 0d89f0f into master May 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the require_history_depth branch May 8, 2019 21:25
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjwwood @ivanpauno