Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent argparse from parsing ROS args in Python demos #396

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Prevent argparse from parsing ROS args in Python demos #396

merged 1 commit into from
Oct 16, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Oct 11, 2019

Precisely what the title says. If ROS args are not removed, argparse chokes on them.

Depends on ros2/rcl#518.

@hidmic
Prevent argparse from parsing ROS args in Python demo nodes.
7902c49 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@wuffle-ros wuffle-ros bot added the in review Waiting for review (Kanban column) label Oct 11, 2019
@hidmic
Copy link
Contributor Author

hidmic commented Oct 15, 2019

CI for demo_nodes_py (linters only):

  • Linux Build Status

@hidmic hidmic changed the title Prevent argparse from parsing ROS args in Python demo nodes. Prevent argparse from parsing ROS args in Python demos Oct 15, 2019
ivanpauno
ivanpauno approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (with green CI)

jacobperron
jacobperron approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but LGTM

@hidmic
Copy link
Contributor Author

hidmic commented Oct 16, 2019

Alright, moving forward.

@hidmic hidmic merged commit a4f354e into master Oct 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-qos-py-demos branch October 16, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @jacobperron @ivanpauno