Fixing deprecated subscriber callback warnings #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscriber callbacks migrated from `SharedPtr` to `ConstSharedPtr` types. This patch affects: - Composition - Intra process - Lifecycle - Topic statistics - Quality of services - Image tools - Demo nodes C++ Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
|
CI (build/test:
|
wjwwood
approved these changes
Aug 21, 2021
`const` is unnecessary because the messages are being copied regardless, and `typename` is unnecessary because the callback types are not templated. Signed-off-by: aprotyas <aprotyas@u.rochester.edu>
These messages are copied anyway, so the `const` specifier is unnecessary. Signed-off-by: aprotyas <aprotyas@u.rochester.edu>
|
Full CI:
|
delete-merged-branch
bot
deleted the
aprotyas/deprecate-shared-ptr-sub-callback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros2/rclcpp#1713 deprecates the
void shared_ptr<T>subscription callback signatures, so this PR migrates away from said signatures.This patch affects the following packages:
Signed-off-by: Abrar Rahman Protyasha abrar@openrobotics.org