Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo_nodes_py] service/client mimic c++ demo behavior #150

Merged
merged 3 commits into from
Jun 29, 2017

Conversation

mikaelarguedas
Copy link
Member

Decided to adress this when debugging services on Windows with @tfoote

The first commit Fixes #145
The second commit calls rclpy.shutdown() at the end of each executable. (I didnt add explicit calls to node.destroy_node() because that should have been fixed by rclpy ros2/rclpy#94)

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jun 29, 2017
@mikaelarguedas
Copy link
Member Author

Actually ros2/rclpy#94 doesn't fix it just report the error properly. the third commit add a call to destroy_node() before shutdown so that the node handle is still valid when trying to destroy it (otherwise shutdown does shut everything down and thus the nodes handles are not valid when the Python node object goes out of scope and tries to destroy itself)

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 29, 2017
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikaelarguedas mikaelarguedas merged commit 2a60907 into master Jun 29, 2017
@mikaelarguedas mikaelarguedas deleted the homogenize_demo branch June 29, 2017 04:47
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_two_ints in python and c++ should have the same behaviour
2 participants