Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match xml schema #167

Merged
merged 1 commit into from
Aug 31, 2017
Merged

match xml schema #167

merged 1 commit into from
Aug 31, 2017

Conversation

mikaelarguedas
Copy link
Member

No description provided.

@mikaelarguedas mikaelarguedas added the in review Waiting for review (Kanban column) label Aug 30, 2017
@mikaelarguedas mikaelarguedas self-assigned this Aug 30, 2017
dirk-thomas
dirk-thomas approved these changes Aug 31, 2017
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. It would probably be best to add a linter for this if we care about schema compliance.

@mikaelarguedas
Copy link
Member Author

It would probably be best to add a linter for this if we care about schema compliance.

Yeah I don't know if we care enough to enforce it automatically, I'd say its a nice-to-have. I just fixed those because I had xmllint running on both my ros1 and ros2 workspaces when investigating ros/rospack#77 and that this was the only non-forked ROS 2 package not complying

@mikaelarguedas mikaelarguedas merged commit 1bd1b46 into master Aug 31, 2017
@mikaelarguedas mikaelarguedas deleted the fix_package_xml branch August 31, 2017 20:46
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@mikaelarguedas mikaelarguedas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelarguedas @dirk-thomas