Do not show freq parameter on help when not necessary #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Dec 12, 2018
image_tools/src/options.cpp
Outdated
| @@ -61,7 +61,9 @@ bool parse_command_options( | |||
| ss << " 1 - reliable (default)" << std::endl; | |||
| ss << " -d: Depth of the queue: only honored if used together with 'keep last'. " << | |||
| "10 (default)" << std::endl; | |||
| ss << " -f: Publish frequency in Hz. 30 (default)" << std::endl; | |||
| if( freq != nullptr ){ | |||
There was a problem hiding this comment.
I would expect this line to fail the linters. Please run the unit tests of the package locally to check.
There was a problem hiding this comment.
Got it. Fixed now
There was a problem hiding this comment.
I'm very sorry. Now it should be fixed.
gonzodepedro
force-pushed
the
gonzalodepedro/freq-param-check
branch
from
b6b8ada
to
80d6436
Compare
gonzodepedro
force-pushed
the
gonzalodepedro/freq-param-check
branch
from
80d6436
to
515f07e
Compare
dirk-thomas
approved these changes
Dec 12, 2018
sloretz
approved these changes
Dec 13, 2018
mjcarroll
approved these changes
Dec 13, 2018
|
Thank you for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not show frequency parameter on image_tools when not necessary. Relate ros2/ros2_documentation#41