Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goal response callback signature #463

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Update goal response callback signature #463

merged 1 commit into from
Sep 21, 2020

Conversation

jacobperron
Copy link
Member

The signature changed in ros2/rclcpp#1311

@jacobperron
Update goal response callback signature
1b47d86 
The signature changed in ros2/rclcpp#1311

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Sep 15, 2020
Merged
@jacobperron
Copy link
Member Author

CI: ros2/rclcpp#1311 (comment)

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

4 similar comments
@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Member

@ros-pull-request-builder retest this please

@clalancette
Copy link
Contributor

@ros-pull-request-builder retest this please

@clalancette
Copy link
Contributor

CI (for this and ros/ros_tutorials#100):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit 11ec490 into master Sep 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/actions_refactor branch September 21, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobperron @ivanpauno @clalancette