Make demo_nodes_cpp_native install stuff only when it builds #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
approved these changes
Nov 11, 2022
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
CI (build:
CI (CycloneDDS only build:
|
delete-merged-branch
bot
deleted the
sloretz__demos__install_nothing_when_not_building
branch
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Make demo_nodes_cpp_native install stuff only when it builds Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * doing nothing -> skipping Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 74db664)
sloretz
added a commit
that referenced
this pull request
Dec 5, 2022
…591) * Make demo_nodes_cpp_native install stuff only when it builds Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * doing nothing -> skipping Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 74db664) Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>
cardboardcode
pushed a commit
to cardboardcode/demos
that referenced
this pull request
Jan 23, 2023
* Make demo_nodes_cpp_native install stuff only when it builds Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * doing nothing -> skipping Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
cardboardcode
pushed a commit
to cardboardcode/demos
that referenced
this pull request
Jan 23, 2023
* Make demo_nodes_cpp_native install stuff only when it builds Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * doing nothing -> skipping Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when using the tarball produced by this job: https://build.ros2.org/view/Hci/job/Hci__nightly-cyclonedds_ubuntu_jammy_amd64/
Rosdep sees
demo_nodes_cpp_nativerequiresrmw_fastrtps_cpp, but the tarball doesn't have that package. This causes rosdep to fail to find a system dependency with that name.The
ament_package()call installs the package.xml and an ament_index entry for thedemo_nodes_cpp_nativepackage, but I don't think it should because the package didn't build anything. This usesreturn()to preventament_package()from being called whenrmw_fastrtps_cppisn't found.