Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix loading parameter behavior from yaml file. #656

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix loading parameter behavior from yaml file. #656

merged 1 commit into from
Dec 15, 2023

Conversation

fujitatomoya
Copy link
Collaborator

address ros2/ros2cli#863

depends on ros2/rclpy#1193

@fujitatomoya
Copy link
Collaborator Author

@iuhilnehc-ynos friendly ping.

@fujitatomoya fujitatomoya mentioned this pull request Nov 2, 2023
Open
iuhilnehc-ynos
iuhilnehc-ynos approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fujitatomoya
fix loading parameter behavior from yaml file.
b093f2f 
  Ref: ros2/ros2cli#863

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@adityapande-1995 adityapande-1995 merged commit eed4553 into rolling Dec 15, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/ros2cli-issue-863 branch December 15, 2023 19:06
adityapande-1995 added a commit that referenced this pull request Dec 15, 2023
@adityapande-1995
Revert "fix loading parameter behavior from yaml file. (#656)"
adb5ab5 
This reverts commit eed4553.
@adityapande-1995 adityapande-1995 mentioned this pull request Dec 15, 2023
Merged
adityapande-1995 added a commit that referenced this pull request Dec 15, 2023
@adityapande-1995
Revert "fix loading parameter behavior from yaml file. (#656)"
b46d073 
This reverts commit eed4553.

Signed-off-by: Aditya Pande <adityapande@google.com>
adityapande-1995 added a commit that referenced this pull request Dec 16, 2023
@adityapande-1995
Revert "fix loading parameter behavior from yaml file. (#656)" (#660)
69aa0e4 
This reverts commit eed4553.

Signed-off-by: Aditya Pande <adityapande@google.com>
fujitatomoya added a commit that referenced this pull request Dec 16, 2023
@fujitatomoya
Revert "Revert "fix loading parameter behavior from yaml file. (#656)" (
ba9283f 
#660)"

This reverts commit 69aa0e4.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@mjeronimo mjeronimo Awaiting requested review from mjeronimo mjeronimo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fujitatomoya @clalancette @mjcarroll @iuhilnehc-ynos @adityapande-1995