Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix loading parameter behavior from yaml file." #660

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Revert "fix loading parameter behavior from yaml file." #660

merged 1 commit into from
Dec 16, 2023

Conversation

adityapande-1995
Copy link
Contributor

Reverts #656 until ros2/rclpy#1193 and ros2/ros2cli#864 are merged.

@adityapande-1995
Revert "fix loading parameter behavior from yaml file. (#656)"
b46d073 
This reverts commit eed4553.

Signed-off-by: Aditya Pande <adityapande@google.com>
@adityapande-1995 adityapande-1995 force-pushed the revert-656-fujitatomoya/ros2cli-issue-863 branch from adb5ab5 to b46d073 Compare December 15, 2023 19:24
@adityapande-1995
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@adityapande-1995 adityapande-1995 merged commit 69aa0e4 into rolling Dec 16, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the revert-656-fujitatomoya/ros2cli-issue-863 branch December 16, 2023 01:39
fujitatomoya added a commit that referenced this pull request Dec 16, 2023
@fujitatomoya
Revert "Revert "fix loading parameter behavior from yaml file. (#656)" (
ba9283f 
#660)"

This reverts commit 69aa0e4.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya mentioned this pull request Dec 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@wjwwood wjwwood wjwwood approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@mjeronimo mjeronimo Awaiting requested review from mjeronimo mjeronimo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityapande-1995 @wjwwood @fujitatomoya