Fix Static Transform Broadcaster Argument Order #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scription Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
allenh1
added
bug
clalancette
approved these changes
Aug 4, 2020
|
I double-checked that this matches the documentation that |
|
|
All right, CI is green for all packages which use static_transform_publisher in the core. I'm going to go ahead and merge this, then open the backport PR for Foxy. Thanks @allenh1 . |
delete-merged-branch
bot
deleted the
revert-static-tf-command-line-order-change
branch
clalancette
pushed a commit
that referenced
this pull request
Aug 4, 2020
…scription (#294) Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
esteve
pushed a commit
to esteve/geometry2
that referenced
this pull request
Dec 9, 2020
Originally PR ros2#294 at ros/geometry2#294 - Adds toMsg for geometry_msgs::Vector3& with dual argument syntax to avoid an overload conflict with geometry_msgs::Point& toMsg(contst Eigen::Vector3d& in) - Adds corresponding fromMsg for Eigen Vector3d and geometry_msgs::Vector3 - Fixed typos in description of fromMsg for Twist and Eigen 6x1 Matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make static_transform_broadcaster consistent with its command line description
Signed-off-by: Hunter L. Allen hunter.allen@ghostrobotics.io
Fixes #292