Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message filters error messages #364

Merged
merged 5 commits into from
Jan 13, 2021
Merged

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Jan 12, 2021

Replace some errors labeled as "unknown" with a more specific label.

Fixes ros2/rviz#443.
Fixes #118.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Jan 12, 2021
@ivanpauno ivanpauno self-assigned this Jan 12, 2021
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

tf2_ros/include/tf2_ros/message_filter.h Outdated Show resolved Hide resolved
tf2_ros/include/tf2_ros/message_filter.h Show resolved Hide resolved
tf2_ros/include/tf2_ros/message_filter.h Outdated Show resolved Hide resolved
ivanpauno and others added 4 commits January 12, 2021 14:58
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tf2_ros/include/tf2_ros/message_filter.h Show resolved Hide resolved
@jacobperron
Copy link
Member

I think this just improves the error message, but doesn't actual resolve the repeated warnings on start-up. I.e. it doesn't fix ros2/rviz#513

@ivanpauno
Copy link
Member Author

I think this just improves the error message, but doesn't actual resolve the repeated warnings on start-up. I.e. it doesn't fix ros2/rviz#513

Sounds good, I don't know if that can be completely fixed though.

@jacobperron
Copy link
Member

I don't know if that can be completely fixed though.

Yeah, I don't know either. This might be something we could hack around in RViz if it seems to be annoying to users. It might be worth leaving the ticket open and report this improvement on the ticket at least.

@clalancette
Copy link
Contributor

Yeah, I don't know either. This might be something we could hack around in RViz if it seems to be annoying to users. It might be worth leaving the ticket open and report this improvement on the ticket at least.

If I understand what you are talking about here, I think this is just a generic problem with tf2. See #358, which I think is related. This change is obviously an improvement so that the error messages are less generic. But I wouldn't be in favor of suppressing them in RViz, just because all other applications that use tf2 probably have similar issues.

@ivanpauno
Copy link
Member Author

not sure if this can affect downstream packages or not, full CI just in case:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 4a6526b into ros2 Jan 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/better-error-msgs branch January 13, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messages from TF message filter Uninformative error messages from MessageFilter
3 participants