Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid timer handle exception (backport #474) #614

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 21, 2023

This is an automatic backport of pull request #474 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add class MockCreateTimerROS for testing

* Add a test case to reproduce invalid timer handle exception

* Fix invalid timer handle exception caused by removing handle repeatedly

(cherry picked from commit 2eaab25)
@ahcorde
Copy link
Contributor

ahcorde commented Jul 21, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 98b92f5 into humble Jul 24, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-474 branch July 24, 2023 12:07
PGotzmann pushed a commit to kin-dergarten/geometry2 that referenced this pull request Sep 21, 2023
* Add class MockCreateTimerROS for testing

* Add a test case to reproduce invalid timer handle exception

* Fix invalid timer handle exception caused by removing handle repeatedly

(cherry picked from commit 2eaab25)

Co-authored-by: Cliff Wu <z800201002005@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants