Using ament_target_dependencies where possible #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Mar 14, 2019
ivanpauno
changed the title
dirk-thomas
reviewed
Mar 15, 2019
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
dirk-thomas
previously approved these changes
Mar 15, 2019
dirk-thomas
reviewed
Mar 15, 2019
| @@ -15,8 +15,6 @@ find_package(tf2 REQUIRED) | |||
| find_package(tf2_ros REQUIRED) | |||
|
|
|||
| find_package(Eigen3 REQUIRED) | |||
| set(Eigen_INCLUDE_DIR "${EIGEN3_INCLUDE_DIR}") | |||
| message(STATUS "Using Eigen3 include dirs: ${Eigen_INCLUDE_DIR}") | |||
There was a problem hiding this comment.
The message should still be kept.
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
dirk-thomas
approved these changes
Mar 15, 2019
ivanpauno
added
in review
|
CI:
All failures are unrelated, so I'm merging |
nuclearsandwich
added a commit
to ros/rosdistro
that referenced
this pull request
Apr 14, 2019
Increasing version of package(s) in repository `geometry2` to `0.11.0-1`: - upstream repository: https://github.com/ros2/geometry2.git - release repository: https://github.com/ros2-gbp/geometry2-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `null` ## tf2 - No changes ## tf2_eigen ``` * Updated to use ament_target_dependencies where possible. (#98 <ros2/geometry2#98>) * Contributors: ivanpauno ``` ## tf2_geometry_msgs ``` * Updated to use ament_target_dependencies where possible. (#98 <ros2/geometry2#98>) ``` ## tf2_msgs - No changes ## tf2_ros ``` * Updated to use node inteface pointers in the MessageFilter class. (#96 <ros2/geometry2#96>) * Updated message_filter.h. (#91 <ros2/geometry2#91>) * Contributors: Michael Jeronimo, Sagnik Basu ``` ## tf2_sensor_msgs - No changes
vmayoral
pushed a commit
to AcutronicRobotics/geometry2
that referenced
this pull request
Apr 26, 2019
* Fixed ros2#658 Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Modified Eigen include directory again Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Deleted custom variable 'Eigen_INCLUDE_DIR' Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * revert unrelated whitespace change Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Added Eigen message again Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
andre-rosa
pushed a commit
to andre-rosa/rosdistro
that referenced
this pull request
May 3, 2019
Increasing version of package(s) in repository `geometry2` to `0.11.0-1`: - upstream repository: https://github.com/ros2/geometry2.git - release repository: https://github.com/ros2-gbp/geometry2-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `null` ## tf2 - No changes ## tf2_eigen ``` * Updated to use ament_target_dependencies where possible. (ros#98 <ros2/geometry2#98>) * Contributors: ivanpauno ``` ## tf2_geometry_msgs ``` * Updated to use ament_target_dependencies where possible. (ros#98 <ros2/geometry2#98>) ``` ## tf2_msgs - No changes ## tf2_ros ``` * Updated to use node inteface pointers in the MessageFilter class. (ros#96 <ros2/geometry2#96>) * Updated message_filter.h. (ros#91 <ros2/geometry2#91>) * Contributors: Michael Jeronimo, Sagnik Basu ``` ## tf2_sensor_msgs - No changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially targets ros2/ros2#658