Fix for issue #431 - Covariance is not transformed in do_transform_pose_with_covariance_stamped #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pose_with_covariance_stamped, corresponding to #431 and made the same changes as the C++ API -Added the tests for do_transform_pose_with_covariance_stamped
aprotyas
requested changes
Sep 5, 2021
aprotyas
reviewed
Sep 5, 2021
Correct the expected test results for covariance matrix Co-authored-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
Correct np array multiplication operator Co-authored-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
- Remove whitespaces between lines - Add a few more helpful comments - Check assertion on pose.orientation as well - Correct check for array equivalence and make expected_covariance as np.array
aprotyas
reviewed
Sep 6, 2021
…_equiv to np.array_equal since we should also check if the shapes of the array are equal.
clalancette
requested changes
Sep 24, 2021
aprotyas
approved these changes
Sep 24, 2021
clalancette
approved these changes
Sep 27, 2021
|
CI:
|
|
All right, CI is looking good. While the crashes on macOS are concerning, they also happened in the nightlies: https://ci.ros2.org/view/nightly/job/nightly_osx_release/2207/#showFailuresLink . So I'm going to go ahead and merge this, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixed the issue of covariance not being transformed in do_transform_pose_with_covariance_stamped, corresponding to #431 and made the same changes in Python as was done in #430
-Added the tests for do_transform_pose_with_covariance_stamped