[tf2_tools] Add graphviz as a runtime dependency
#483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this runtime dependency, the subprocess used to invoke the `dot` utility that ships with `graphviz` silently dies, and a `frames.pdf` file is not generated. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
|
CI:
|
clalancette
approved these changes
Dec 8, 2021
|
Green CI + approval, so I'll merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to backporting #351 since that requires
tf2_ros_py, among other difficulties.Without this runtime dependency, the subprocess used to invoke the
dotutility that ships with
graphvizsilently dies, and aframes.pdffile is not generated.
Closes #482.
Signed-off-by: Abrar Rahman Protyasha aprotyas@u.rochester.edu