Include required header Scalar.h #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
requested changes
Nov 7, 2022
tf2/include/tf2/LinearMath/MinMax.h
Outdated
| @@ -17,6 +17,8 @@ subject to the following restrictions: | |||
| #ifndef GEN_MINMAX_H | |||
| #define GEN_MINMAX_H | |||
|
|
|||
| #include <tf2/LinearMath/Scalar.h> | |||
There was a problem hiding this comment.
For better or worse, the style used here (as seen in QuadWord.h and Vector3.h) seems to be:
Suggested change
| #include <tf2/LinearMath/Scalar.h> | |
| #include "Scalar.h" |
methylDragon
approved these changes
Nov 7, 2022
54 tasks
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
CI (build:
|
clalancette
approved these changes
Nov 11, 2022
|
@Mergifyio backport humble galactic foxy |
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
* Include required header Scalar.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * brackets to quotes Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 7719d62)
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
* Include required header Scalar.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * brackets to quotes Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 7719d62)
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
* Include required header Scalar.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * brackets to quotes Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 7719d62)
timdietereberhardt
pushed a commit
to timdietereberhardt/geometry2
that referenced
this pull request
Nov 26, 2022
* Include required header Scalar.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * brackets to quotes Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 7719d62) Issue 1: Can't import tf2_sensor_msgs package from own .py file Added 'ament_python_install_package(${PROJECT_NAME})' to build the Python package. To use the command, it's necessary to put the py Files in /tf2_sensor_msgs/tf2_sensor_msgs Issue 2: For using create_cloud() in tf2_sensor_msgs.py the input must be a list with 16 properties instead of 3 Next to the new transformed x,y,z cloud values from the variable "p_out" the other old data (Range, Speed, ..) from a new varable "points" will be safed in the list "points_out". Issue 3: The package "rospy" is only for ROS1 Delete import rospy
clalancette
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Include required header Scalar.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * brackets to quotes Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 7719d62) Co-authored-by: Shane Loretz <sloretz@openrobotics.org>
clalancette
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Include required header Scalar.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * brackets to quotes Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 7719d62) Co-authored-by: Shane Loretz <sloretz@openrobotics.org>
clalancette
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Include required header Scalar.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * brackets to quotes Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 7719d62) Co-authored-by: Shane Loretz <sloretz@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed downstream code was working around this bug here: https://github.com/locusrobotics/tf2_2d/blob/beb6a7a29fcdba7abb1540d9524e81cb9795b9ac/include/tf2_2d/rotation_impl.h#L37-L38
Scalar.his needed for theTF2SIMD_FORCE_INLINEvalue to be defined.