Remove use of python_cmake_module #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Feb 16, 2024
|
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
44cfeb9
to
c12cded
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
2 times, most recently
from
f8aa563
to
74cd02b
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
74cd02b
to
06cd4e5
Compare
We really don't need it anymore, and can just use the builtin find_package(Python3). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
06cd4e5
to
9d47878
Compare
|
CI for this (along with all of the rest of the changes needed) is in ros2/ros2#1524 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really don't need to use it anymore. While we are here, add in hints so that we find python3 more appropriately.
This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.